Skip to content

fix(metadata): fix thunk type detection #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kerwanp
Copy link
Contributor

@kerwanp kerwanp commented Jan 27, 2025

Changes

This pull request closes #2123 by improving the thunk detection regex () => User.

How to Review

A new added test that was failing before is now passing properly with new changes.

Checklist

  • Unit tests updated

@kerwanp kerwanp requested a review from a team as a code owner January 27, 2025 19:10
@kerwanp kerwanp requested a review from drwpow January 27, 2025 19:10
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 00e4d8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-metadata Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for openapi-ts canceled.

Name Link
🔨 Latest commit 00e4d8e
🔍 Latest deploy log https://app.netlify.com/sites/openapi-ts/deploys/6797da1b56c1ad000843755e

Copy link
Contributor

size-limit report 📦

Path Size
packages/openapi-fetch/dist/index.min.js 6.47 KB (0%)

@drwpow drwpow merged commit a041c2d into main May 10, 2025
14 checks passed
@drwpow drwpow deleted the 2123-open-api-throws-class-constructor-user-cannot-be-invoked-without-new-when-trying-to-use-map-in-adonis-computed-field-in-model branch May 10, 2025 14:15
@openapi-ts-bot openapi-ts-bot mentioned this pull request May 10, 2025
jawnothin added a commit to augwa/openapi-typescript that referenced this pull request May 17, 2025
* Update schema-object.ts

* chore(deps): update dependency msw to v2.7.6 (openapi-ts#2287)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/node to v22.15.10 (openapi-ts#2293)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @shikijs/vitepress-twoslash to v3.4.0 (openapi-ts#2298)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @arethetypeswrong/cli to ^0.18.0 (openapi-ts#2272)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency execa to v9.5.3 (openapi-ts#2303)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(metadata): fix thunk type detection (openapi-ts#2125)

* Don't remove `null` type if a default is present. (openapi-ts#2145)

* Don't remove `null` type if a default is present.

* Don't remove `null` type from enums if default is present.

* Don't remove `null` type if default is present (legacy)

* [ci] release (openapi-ts#2307)

* [ci] release

* Add 2145 manually

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Drew Powers <drew@pow.rs>

* chore(deps): update dependency @types/react to v18.3.21 (openapi-ts#2218)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(openapi-fetch): fix overriding baseUrl per request without overriding default baseUrl (openapi-ts#2157)

* Support $ref into `paths` (openapi-ts#2185)

* React query handle 204 or zero content length (openapi-ts#2235)

* fix(openapi-react-query): Handle 204 or zero Content-Length header by returning data as null

* fix(openapi-react-query): updated and added 204 & zero Content-Length queryFn tests

* chore(openapi-react-query): Fixed linting in test

* chore(deps): update dependency @arethetypeswrong/cli to v0.18.1 (openapi-ts#2306)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency msw to v2.8.2 (openapi-ts#2304)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Speakeasy URL (openapi-ts#2302)

* chore(deps): update dependency @tanstack/react-query to v5.75.7 (openapi-ts#2301)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency lint-staged to v15.5.2 (openapi-ts#2297)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(swr-openapi): add custom error types to query builder (openapi-ts#2147)

* chore(deps): update vitest monorepo to v3 (openapi-ts#2284)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Encode the request body if Content-Type set (openapi-ts#2096)

* Improve header handling (openapi-ts#2308)

* [ci] release (openapi-ts#2309)

* [ci] release

* Release additional packages

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Drew Powers <drew@pow.rs>

* chore: update openapi-fetch test fixture (openapi-ts#2313)

* Build packages with unbuild to improve CJS support (openapi-ts#2310)

* [ci] release (openapi-ts#2314)

* [ci] release

* Fix major bump

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Drew Powers <drew@pow.rs>

* Update code of conduct source (openapi-ts#2316)

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>

---------

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Martin Paucot <contact@martin-paucot.fr>
Co-authored-by: Theron Luhn <theron@luhn.com>
Co-authored-by: openapi-ts-bot <openapi-ts@googlegroups.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Drew Powers <drew@pow.rs>
Co-authored-by: Luis Merino <mail@luismerino.name>
Co-authored-by: Duncan Beevers <duncan@dweebd.com>
Co-authored-by: Wheelebin <wheelebin@users.noreply.github.com>
Co-authored-by: Nolan Di Mare Sullivan <nolan.dm.sullivan@gmail.com>
Co-authored-by: しゅーまい <62363188+SSlime-s@users.noreply.github.com>
Co-authored-by: Olga Bulat <obulat@gmail.com>
Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants